Update window open handler to accept new allowlisted protocols #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Follow on to #151, I missed a spot here when I updated our allowlisted protocols to include
replit://
andvscode://
. We need to update the window open handler logic to match that of thewill-navigate
event handler to account for URLs opened viatarget="_blank"
and programmatically viawindow.open
. This ensures the behavior will be consistent to what we see in thewill-navigate
handler which fires in all other cases.What changed
Update window open handler to accept new allowlisted protocols to match what we do in the will nav handler so that
target=_blank
andwindow.open
work as expected.Test plan
window.open("replit://new")