Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

everything is unstable #184

Merged
merged 5 commits into from
Nov 28, 2023
Merged

everything is unstable #184

merged 5 commits into from
Nov 28, 2023

Conversation

cdmistman
Copy link
Contributor

Why

it's annoying having multiple nix channels that affect some modules but not others. also it's a lot easier to keep things up-to-date and consistent when we're only using 1 channel. also 23.05 is almost deprecated, and our choices were to either:

  • upgrade to 23.11
  • stick with 23.05 as it becomes more and more out-of-date (things aren't always backported to the stable channel!)

What changed

  • removed nixos-23.05 channel input
  • changed everything to rely on nixpkgs-unstable instead
  • update usage of graalvm due to upstream changes in how graalvm is versioned
    • this is ok because afaict we're not using the java nixmodule anywhere anyways! will need to test more extensively once we move java templates over though
  • removed the python 3.8 nixmodule from the current modules list due to a version incompatibility with sphinx (which i guess is somewhere in the dep tree)

Test plan

  • template tests still pass :)

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

(import ./python {
python = pkgs.python38Full;
pypkgs = pkgs.python38Packages;
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we getting rid of python 3.8?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see

removed the python 3.8 nixmodule from the current modules list due to a version incompatibility with sphinx (which i guess is somewhere in the dep tree)

What's the error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like sphinx-x.x.x is not a valid interpreter for python 3.8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was an error printed by nix (not printed from within a drv) so i think this is just an incompatibility with the latest unstable

@cdmistman cdmistman requested a review from a team as a code owner November 27, 2023 20:16
@cdmistman cdmistman requested review from ryantm and removed request for a team November 27, 2023 20:16
@cdmistman cdmistman force-pushed the cad/everything-is-unstable branch 5 times, most recently from 75b72fb to b382abc Compare November 27, 2023 21:11
@cdmistman cdmistman force-pushed the cad/everything-is-unstable branch 7 times, most recently from 02fc046 to b9e490e Compare November 28, 2023 17:05
@cdmistman cdmistman merged commit 9a623f6 into main Nov 28, 2023
2 checks passed
@cdmistman cdmistman deleted the cad/everything-is-unstable branch November 28, 2023 21:43
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants