Skip to content

Commit

Permalink
EPMRPP-93626 || Notifications. "Configure Integration" link doesn't l… (
Browse files Browse the repository at this point in the history
  • Loading branch information
Vadim73i authored Aug 29, 2024
1 parent f522a1d commit c97580d
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 9 deletions.
8 changes: 4 additions & 4 deletions app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@formatjs/intl-pluralrules": "1.3.9",
"@formatjs/intl-relativetimeformat": "4.5.1",
"@formatjs/intl-utils": "1.6.0",
"@reportportal/ui-kit": "^0.0.1-alpha.20",
"@reportportal/ui-kit": "^0.0.1-alpha.24",
"axios": "1.6.4",
"c3": "0.7.20",
"chart.js": "2.9.4",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { isInternalLink } from '../utils';

const cx = classNames.bind(styles);

export const LinkComponent = ({ to, children, icon, className, event, automationId }) => {
export const LinkComponent = ({ to, children, icon, className, event, automationId, target }) => {
const { trackEvent } = useTracking();
const handleLinkTracking = () => {
trackEvent(event);
Expand All @@ -35,7 +35,7 @@ export const LinkComponent = ({ to, children, icon, className, event, automation
to={to}
onClick={handleLinkTracking}
className={cx(className)}
target={'_blank'}
target={target}
data-automation-id={automationId}
>
{children}
Expand All @@ -46,7 +46,7 @@ export const LinkComponent = ({ to, children, icon, className, event, automation
onClick={handleLinkTracking}
href={to}
className={cx(className)}
target={'_blank'}
target={target}
rel="noopener noreferrer"
data-automation-id={automationId}
>
Expand All @@ -69,9 +69,11 @@ LinkComponent.propTypes = {
event: PropTypes.object,
className: PropTypes.string,
automationId: PropTypes.string,
target: PropTypes.oneOf(['_blank', '_self', '_parent', '_top']),
};
LinkComponent.defaultProps = {
className: 'link-item-wrapper',
icon: null,
automationId: null,
target: '_blank',
};
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,16 @@ export const RuleGroup = ({ pluginName, ruleDescription, rules, isPluginEnabled,
payload: {
projectId: activeProject,
settingsTab: INTEGRATIONS,
subTab: 'email',
},
meta: {
query: {
subPage: 'email',
},
},
}}
icon={arrowRightIcon}
event={PROJECT_SETTINGS_NOTIFICATIONS_EVENTS.CLICK_CONFIGURE_INTEGRATION_LINK}
target="_self"
>
{formatMessage(messages.configureIntegration)}
</LinkComponent>
Expand Down

0 comments on commit c97580d

Please sign in to comment.