Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-90288 || Help and Services. 'Request support' modal redesign #3841

Conversation

maria-hambardzumian
Copy link
Contributor

@maria-hambardzumian maria-hambardzumian commented May 23, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

Copy link
Member

@AmsterGet AmsterGet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the form submission? The fields are not being submitted.
Probably because the name property is not set for the input (FieldText).
Please check this.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.13%. Comparing base (5713426) to head (034e804).

Additional details and impacted files
@@              Coverage Diff              @@
##           feature/orgs    #3841   +/-   ##
=============================================
  Coverage         61.13%   61.13%           
=============================================
  Files                80       80           
  Lines               867      867           
  Branches            127      127           
=============================================
  Hits                530      530           
  Misses              311      311           
  Partials             26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AmsterGet
AmsterGet previously approved these changes May 27, 2024
@maria-hambardzumian maria-hambardzumian force-pushed the feature/EPMRPP-90288-redesign-Request-support-modal branch from 8e2e0fd to 12dd7c0 Compare May 27, 2024 11:09
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@maria-hambardzumian maria-hambardzumian merged commit 477df19 into feature/orgs May 27, 2024
7 checks passed
@maria-hambardzumian maria-hambardzumian deleted the feature/EPMRPP-90288-redesign-Request-support-modal branch May 27, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants