Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-100064 || Exclude spaces from password validation #4248

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

BlazarQSO
Copy link
Contributor

@BlazarQSO BlazarQSO commented Mar 10, 2025

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you checked that no new circular dependencies appreared with your changes? (the webpack plugin reports circular dependencies within the dev npm script)
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

@BlazarQSO BlazarQSO removed the request for review from AmsterGet March 10, 2025 05:11
Copy link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.12%. Comparing base (5f258b0) to head (38abf97).

Additional details and impacted files
@@            Coverage Diff             @@
##           rc/5.12.5    #4248   +/-   ##
==========================================
  Coverage      61.12%   61.12%           
==========================================
  Files             81       81           
  Lines            908      908           
  Branches         136      136           
==========================================
  Hits             555      555           
  Misses           325      325           
  Partials          28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BlazarQSO BlazarQSO merged commit ed1cd71 into rc/5.12.5 Mar 10, 2025
6 checks passed
@BlazarQSO BlazarQSO deleted the fix/EPMRPP-100064-exclude-spaces branch March 10, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants