-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .dockerignore files #13
base: master
Are you sure you want to change the base?
Add support for .dockerignore files #13
Conversation
87fa9ce
to
f6ddf9f
Compare
Signed-off-by: Tristan Pemble <[email protected]>
f6ddf9f
to
853cfc3
Compare
@@ -55,6 +57,7 @@ func frontendBuild(nixImage string) client.BuildFunc { | |||
localDfSt := llb.Local(localNameDockerfile, | |||
llb.SessionID(c.BuildOpts().SessionID), | |||
dockerfile2llb.WithInternalName("local dockerfile"), | |||
llb.FollowPaths([]string{dfName}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually going to get complicated.. relative Nix paths in the Dockerfile won't work anymore since this is being copied to /dockerfile/{dfName}
and the context is in /context
Thanks, but looks like flake.lock is no longer copied into the dockerfile ctx?
https://github.com/AkihiroSuda/buildkit-nix/runs/5291062997?check_suite_focus=true |
Implements #12. This seems to work with my limited testing.
This is my first time writing or contributing anything in Go, so, caveat emptor