Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rescue from Seahorse::Client::NetworkingError #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

rescue from Seahorse::Client::NetworkingError #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/wrapbox/runner/ecs/task_waiter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ def update_described_results(interval)
end

@cv.broadcast
rescue Seahorse::Client::NetworkingError => e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following code is simpler and better:

rescue Aws::ECS::Errors::ThrottlingException, Seahorse::Client::NetworkingError => e
  Wrapbox.logger.warn("Failed to describe tasks: #{e} (#{e.class})")
end

What do you think?

Wrapbox.logger.warn("Failed to connect to ECS #{e}")
rescue Aws::ECS::Errors::ThrottlingException
Wrapbox.logger.warn("Failed to describe tasks due to Aws::ECS::Errors::ThrottlingException")
end
Expand Down