-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Takeover of PR #388 (Scope NUnit parallelization to generated classes instead of assembly-level) #432
Conversation
Plugins/Reqnroll.NUnit.Generator.ReqnrollPlugin/build/NUnit.AssemblyHooks.template.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we replace the use of these custom functions with the more idiomatic form of
CodeTypeReference?
Example: new CodeTypeReference(typeof(Io.Cucumber.Messages.Types.Source), CodeTypeReferenceOptions.GlobalReference);
I've not verified that this works properly for VB generation but I would presume that it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. That's a good hint. I didn't know that that exists. We can try it in a new PR...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not verified that this works properly for VB generation but I would presume that it does.
Added a test to Messages for code gen using VB and this form of the CodeTypeReference api works as expected.
We should switch over to it as the custom function we have today for globalizing type names doesn't support VB.
I volunteer to draft the PR, but can wait until after this PR goes in.
Hey @gasparnagy is there a timeframe of when this will be released? |
On the original issue they said early 'next' (ie now this) week |
🤔 What's changed?
Taken over from #388, see details there
⚡️ What's your motivation?
Fixes #379
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.