Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUnit test framework #442

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AdaskoTheBeAsT
Copy link
Contributor

🤔 What's changed?

Added implementation of TUnit Provider

⚡️ What's your motivation?

This is completelly new feature for test framework based on source generation

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

I am not sure if this is proper way of creating plugin - I tried to adjust all the stuff similar to NUnit xUnit and MSTest implementation.

📋 Checklist:

  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

@thomhurst
Copy link

Will this work? Tunit uses source generators and so does reqnroll. Source generated code can't see other source generated code so it may not be able to generate test cases: https://github.com/orgs/reqnroll/discussions/418

@AdaskoTheBeAsT
Copy link
Contributor Author

it is beginning but apparently yes
image

@thomhurst
Copy link

Nice work 😁

@gasparnagy
Copy link
Contributor

gasparnagy commented Feb 11, 2025

@AdaskoTheBeAsT This looks pretty good so far. 🤘

One small comment: traditionally the unit test provider classes have been added to the UnitTestProvider folder of the generator project, but this was because at that time we did not have a plugin system. In your case, you can (and you should IMHO) put your unit test provider class to the generator plugin project and add move the registration to the plugin class like we do for example here.

(In principle we should have moved the NUnit/xUnit/MsTest stuff as well to their plugins, just we haven't done that yet.)

@AdaskoTheBeAsT AdaskoTheBeAsT force-pushed the feature/TUnit-test-framework branch from ff3f88a to 0ec0eb7 Compare February 12, 2025 00:21
@AdaskoTheBeAsT
Copy link
Contributor Author

@gasparnagy thanks for feedback I moved that registration to plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants