Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of datetime.utcnow() (deprecated in python 3.12) #243

Merged
merged 1 commit into from
May 29, 2024

Conversation

JWCook
Copy link
Member

@JWCook JWCook commented May 28, 2024

Fixes #237; related to #195

Note: a future improvement would be to start using timezone-aware datetime objects, but this will cause problems with existing cache data (can't compare timezone-aware and timezone-naive datetimes). It would be best to do this at the same time as a release that includes changes to request matching logic (i.e., new cache keys).

@JWCook JWCook added the bug Something isn't working label May 28, 2024
@JWCook JWCook added this to the v0.12 milestone May 28, 2024
@JWCook JWCook requested a review from alessio-locatelli May 28, 2024 18:33
@alessio-locatelli alessio-locatelli merged commit 188dce7 into main May 29, 2024
6 checks passed
@JWCook JWCook deleted the utcnow branch May 30, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datetime.utcnow is deprecated
2 participants