Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address cases where MultipartEncoder source stream grows or shrinks mid-way through encoding, leading to malformed requests #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cpfair
Copy link

@cpfair cpfair commented Sep 24, 2021

Previously, MultipartEncoder in conjunction with requests could produce a malformed request if the source data stream grew (e.g. appending to a log file being uploaded) or shrunk during encoding. This change addresses both the growing case (by only transmitting the originally promised amount of data) and the shrinking case (by raising an exception).

Note that the data produced by MultipartEncoder itself was well formed. The issue occurs when downstream code makes promises or assumptions based on the initial len (e.g. transmitting it to the server as Content-Length, as requests does), only to have the encoder return more/less data. This change may break (presumably rare) use cases that rely on both a) on shrinking/growing the source data stream during encoding, and b) don't already fail due to the promised/actual encoded data length mismatch.

…id-way through encoding

Previously, MultipartEncoder in conjunction with requests could produce
a malformed request if the source data stream grew (e.g. appending to a
log file being uploaded) or shrunk during encoding. This change
addresses both the growing case (by only transmitting the originally
promised amount of data) and the shrinking case (by raising an
exception).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant