deposit: add new file component #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes useless detailed views. * Redirects to the search view after record edition. * Uses short editor when it is possible. * Uses a generic component to display fields in detailed views. * Removes useless test files. Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma
force-pushed
the
maj-deposit-files
branch
2 times, most recently
from
946d38a
to
af6c58d
Compare
- Fixes missing spinner. - Adds legacy browsers support. - Refactors the deposit edition. - Splits the deposit editor component into serveral samller components. - Uses primeng component for the deposition. Co-Authored-by: Johnny Mariéthoz <[email protected]>
Garfield-fr
approved these changes
Sep 9, 2024
| @@ -28,7 +28,7 @@ <h1>{{ 'Confirmation' | translate }}</h1> | |||
| <a [href]="publicInterfaceLink" translate>Back to public interface</a> | |||
| </li> | |||
| <li> | |||
| <a routerLink="/deposit/0/create" translate>Deposit another publication</a> | |||
| <a routerLink="/deposit/create" translate>Deposit another publication</a> | |||
There was a problem hiding this comment.
array def on routerLink ?
Comment on lines
+21
to
+40
| @if(currentStep() === 'metadata') { | ||
| <p-splitButton | ||
| [label]="'Import metadata' | translate" | ||
| [model]="importMenuItems" | ||
| /> | ||
| } @if(currentStep() === 'diffusion') { | ||
| <p-button | ||
| class="m-2" | ||
| (click)="save()" | ||
| [label]="'Save' | translate" | ||
| iconPos="right" | ||
| /> | ||
| } @else { | ||
| <p-button | ||
| class="m-2" | ||
| (click)="save()" | ||
| icon="pi pi-chevron-right" | ||
| [label]="'Continue' | translate" | ||
| iconPos="right" | ||
| /> |
There was a problem hiding this comment.
@switch(currentStep()) {
case "metadata":
...
break;
case "diffusion":
...
break;
@default {
...
}
}
| this.activeIndex = 0; | ||
| this.deposit.set(result[0].metadata); | ||
|
|
||
| // TODO: solve this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.