Make the path to ffmpeg customisable
#8100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
added
exclude from changelog
abey79
force-pushed
the
antoine/ffmpeg-path-config
branch
from
e3b83ca
to
433763a
Compare
emilk
approved these changes
Nov 13, 2024
| /// Don't use this field directly, use [`AppOptions::video_decoder_settings`] instead. | ||
| /// | ||
| /// Implementation note: we avoid using `Option<PathBuf>` here to avoid loosing the user-defined | ||
| /// path when disabling the override. |
| @@ -100,6 +99,9 @@ fn settings_screen_ui_impl(ui: &mut egui::Ui, app_options: &mut AppOptions, keep | |||
| ui.strong("Map view"); | |||
|
|
|||
| ui.horizontal(|ui| { | |||
| // TODO(ab): needed for alignment, we should use egui flex instead | |||
| ui.set_height(19.0); | |||
There was a problem hiding this comment.
Why 19 though? Aren't most things in our ui 20 heigh?
There was a problem hiding this comment.
I basically used what the edit text told me it needs with the debug overlay
|
confirmed to work like a charm on Windows! |
Wumpf
reviewed
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Makes the path to
ffmpegcustomisable. Also hides the auto/soft/hard choice on native as it has not impact.Export-1731429356460.mp4
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.