Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't shade GeoPoints in the map view #8110

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Don't shade GeoPoints in the map view #8110

merged 1 commit into from
Nov 13, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 13, 2024

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added enhancement New feature or request 🔺 re_renderer affects re_renderer itself exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view labels Nov 13, 2024
@teh-cmc teh-cmc changed the title don't shade geopoints Don't shade GeoPoints in the map view Nov 13, 2024
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's weirdly sidestepping the batch builder mechanism (why don't add a flags builder method?), but you know what I actually like it. I'm not so fond of builder pattern anyways when it can be avoided

@teh-cmc
Copy link
Member Author

teh-cmc commented Nov 13, 2024

that's weirdly sidestepping the batch builder mechanism (why don't add a flags builder method?), but you know what I actually like it. I'm not so fond of builder pattern anyways when it can be avoided

Yeah I only realized that was a thing until after I was done and had a look at how the GeoLines do it... but then I was already done, you know 😶

@teh-cmc teh-cmc merged commit cf66bd0 into main Nov 13, 2024
45 checks passed
@teh-cmc teh-cmc deleted the cmc/flat_map_points branch November 13, 2024 10:08
Wumpf pushed a commit that referenced this pull request Nov 13, 2024
### What

☝🏻 

Also updated a bunch of screenshot to show the flat points (#8110).

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8121?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8121?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/8121)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exclude from changelog PRs with this won't show up in CHANGELOG.md feat-map-view Everything related to the map view 🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants