Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM example: Fewer log-lines and all static data #8116

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

nikolausWest
Copy link
Member

@nikolausWest nikolausWest commented Nov 13, 2024

What

⬆️

Code more like this:

rr.log(
    entity_path,
    rr.GeoLineStrings(lat_lon=[coords], radii=rr.components.Radius.ui_points(2.0)),
    rr.AnyValues(**way.get("tags", {})),
    static=True,
)

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@nikolausWest nikolausWest added examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 13, 2024
@nikolausWest nikolausWest added this to the 0.20 - Maps, H.264 milestone Nov 13, 2024
@nikolausWest nikolausWest merged commit 735f39e into main Nov 13, 2024
40 of 41 checks passed
@nikolausWest nikolausWest deleted the niko/osm-example-fixes branch November 13, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants