Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate, instantiate, nor carry Arrow extensions around #8153

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 14, 2024

  • Do not generate, instantiate, nor carry Arrow extensions around: we do not need them, ever. We rely on chunk metadata for everything meta-esque.
  • Do not let datatypes pretend that they have semantics. They do not need names.
  • Clean everything accordingly.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

To deploy documentation changes immediately after merging this PR, add the deploy docs label.

@teh-cmc teh-cmc added enhancement New feature or request 🐍 Python API Python logging API do-not-merge Do not merge this PR 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 14, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Nov 14, 2024

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/11842783240

Base automatically changed from cmc/no_log_components to main November 14, 2024 18:00
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Nov 14, 2024
@abey79 abey79 self-requested a review November 15, 2024 08:35
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Feel good PR of the year" contender. Changes looks rather straightforward too 👍🏻

@teh-cmc teh-cmc merged commit 71d8601 into main Nov 15, 2024
40 of 41 checks passed
@teh-cmc teh-cmc deleted the cmc/get_rid_of_py_extensions branch November 15, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants