Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gh-pages hosted rust doc while doc.rs docs are broken #8166

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 17, 2024

What

Temporary workaround for:

Please revert after we published a patch with working doc.rs

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

To deploy documentation changes immediately after merging this PR, add the deploy docs label.

@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md deploy docs Once this PR is merged to main, the resulting commit will be cherry-picked to docs-latest labels Nov 17, 2024
Copy link

github-actions bot commented Nov 17, 2024

Latest documentation preview deployed successfully.

Result Commit Link
5c7d50c https://landing-pneuc8bbe-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

Copy link

Your changes can be cherry-picked to docs-latest and will be deployed
immediately after merging.

@Wumpf Wumpf force-pushed the andreas/workaround-broken-docsrs branch from c036e87 to 5c7d50c Compare November 17, 2024 14:14
@Wumpf Wumpf merged commit cf9299d into main Nov 17, 2024
35 of 37 checks passed
@Wumpf Wumpf deleted the andreas/workaround-broken-docsrs branch November 17, 2024 14:23
rerun-bot pushed a commit that referenced this pull request Nov 17, 2024
### What

Temporary workaround for:
* #8165

Please revert after we published a patch with working doc.rs

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8166?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8166?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/8166)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy docs Once this PR is merged to main, the resulting commit will be cherry-picked to docs-latest 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant