Sys.argv, Sys.max_array_length, Sys.max_string_length are working

[MoOx]

I tried this

Js.log(Sys.argv);

Js.log(Sys.max_array_length);

Js.log(Sys.max_string_length);

(compiled to)

// Generated by BUCKLESCRIPT VERSION 3.1.5, PLEASE EDIT WITH CARE
'use strict';

var Sys = require("bs-platform/lib/js/sys.js");

console.log(Sys.argv);

console.log(Sys.max_array_length);

console.log(Sys.max_string_length);

/*  Not a pure module */

And got this

❯ ./index.js lol
[ '/Users/MoOx/.nvs/node/8.11.1/x64/bin/node',
  '/Users/MoOx/Sync/Development/git-init/index.js',
  'lol' ]
2147483647
2147483647

(index.js import my Module.re via .bs.js suffix)

[MoOx]

Maybe I should only have removed Sys.argv?

[bobzhang]

the thing is such configuration does not sound very meaningful in js context

[chenglou]

So, should this be merged?

[zploskey]

I'm not quite sure how to interpret "it might be respected". The max seems to be respected, currently. For example, trying to create a string with String.make(Sys.max_string_length + 1, 'c'); overflows and throws an exception Invalid_argument,-3,String.create. At least the part about Sys.argv could be removed.