Contact person improvements

[ewan-escience]

Contact person improvements

Changes proposed in this pull request:

• Contact persons are not shown in the regular list of contributors anymore.
• Each contact person is now shown as such, instead of only one (which was the first one returned from the API).

How to test :

• docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
• Login as admin
• Edit a software page so that multiple people, up to everyone, is a contact person, inspect the page
• Make it such that no one is a contact person, inspect the page

I suspect that this might spark some discsussion, go ahead. 😉

Closes #885

Closes #948

PR Checklist:

• Increase version numbers in docker-compose.yml
• Link to a GitHub issue
• Update documentation
• Tests

[sonarqubecloud]

[rsd-frontend] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[dmijatovic]

@ewan-escience I had a look at it. Technically it works but we should change design if we want to support multiple contacts.

I would advice to design new contributor card, have a contact person badge (or some other visual "sign") and show these at the top of the list. This will make layout lot easier to manage. The current design is not optimal for having multiple contact persons in my opinion. I am interested to hear what others think @jmaassen, @ctwhome, @cmeessen .

[ewan-escience]

I agree, but I think that in production most pages have 0 or 1 contact persons.

[dmijatovic]

I propose to decide first on the following issues and create design to optimally cover the needs.

• decide whether we need to have contact info or contact person(s). I see a difference between contact info and contact person. The contact info should be a single instance in my opinion and should have own section on the software page, separate from the contributors.
• if we choose to have contact person(s) then I suggest two separate sections (one for contributors and one for contacts). One person can be contributor and the contact person, I see these as two separate "roles".

@jmaassen @ewan-escience @cmeessen @ctwhome @fembau What do you think?

[ewan-escience]

Closed in favour of #1161.