-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
986 reference papers #1011
986 reference papers #1011
Conversation
481cdbb
to
d181665
Compare
036339d
to
c04fd57
Compare
Works well, but I did find a bug: Papers that have been scraped, and are later added as reference papers in other software do not seem to be scraped themselves. I did the following:
make start
docker compose down --volumes
docker compose up --scale data-generation=0 --scale scrapers=1 --detach Next, sign in and create a software called "test". Add the following reference paper:
Then run the scraper using docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.doi.MainCitations The software should now have 11 "referenced by" papers
docker compose down --volumes
docker compose up --scale data-generation=0 --scale scrapers=1 --detach Sign in and create a software called "test1". Add the following reference paper:
Then run the scraper using docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.doi.MainCitations The software should now have 14 "referenced by" papers. Note that this includes the paper we used in step 1 Next, create a software called "test2" and add this first reference paper again:
When adding, this paper shows "OpenAlex" as source. Run the scrapers again (and again). Regardless of how many times I run the scraper, the "referenced by" count for "test2" remains zero. |
9ff7827
to
fc931f1
Compare
fc931f1
to
d1a79b8
Compare
[rsd-database] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[scrapers] Kudos, SonarCloud Quality Gate passed! |
[rsd-frontend] SonarCloud Quality Gate failed. 0 Bugs 4.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine with the new fixes
Add reference papers to software edit section
Closes #289
Closes #756
Closes #986
Changes proposed in this pull request:
How to test:
make start
to build app, after app is started you will need to stop it and start it with scrapers. You can usedocker compose down && docker compose up -d
CDK reference test
so you can find it easily later,no items to show
messages and provide improvement suggestions (if any)docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.doi.MainCitations
Start screen reference papers page
Added reference papers
Scraper found some citations
PR Checklist:
docker-compose.yml