improve software categories #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fembau
force-pushed
the
improve-software-categories
branch
from
b77b4f1 to
6b520c0
Compare
|
Categories which are marked as `is_highlight` are visually brought out. In the software edit view they get an extra dropdown menu and in the software view they have an extra section in the main content area. Categories on different levels in the hierarchy could have different extra properties. These are now aggregated in one database column `properties` of type JSONB.
fembau
force-pushed
the
improve-software-categories
branch
from
6b520c0 to
afff730
Compare
Use ontology mapping techniques like exactMatch from SKOS. https://www.w3.org/TR/skos-reference/#mapping
…gories frontend/components/software/edit/links/AutosaveSoftwareCategories.tsx
|
Implementation of table representation is moved into another PR to speed up community feature PR |
|
@fembau To fix failing unit test please add empty categories array to const softwarePageData = {
slug: 'test-slug',
software: softwareItem,
citationInfo: SoftwareCitationItems,
keywords: apiKeywordsBySoftware,
licenseInfo,
repositoryInfo: repoInfo,
mentions: apiMentions,
testimonials: apiTestimonial,
contributors: apiContributors,
relatedTools: apiRelatedSoftware,
relatedProjects: apiRelatedProjects,
isMaintainer: false,
organisations: apiOrganisationsOfSoftware,
// add categories to mock data
categories:[]
} |
fembau
requested review from
dmijatovic and
cmeessen
and removed request for
dmijatovic
cmeessen
approved these changes
Jun 3, 2024
dmijatovic
reviewed
Jun 3, 2024
frontend/components/software/edit/links/AutosaveSoftwareCategories.tsx
Outdated
Show resolved
Hide resolved
dmijatovic
reviewed
Jun 3, 2024
dmijatovic
reviewed
Jun 3, 2024
dmijatovic
approved these changes
Jun 3, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
see #984