Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use OpenAlex for all unsupported DOI registry agents #1323

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ewan-escience
Copy link
Collaborator

Use OpenAlex for unsupported DOI RAs

Changes proposed in this pull request

  • On the frontend, when searching for a DOI that is not from Crossref or DataCite, use OpenAlex instead
  • Same when bulk importing on the frontend
  • Same for the mentions scraper

How to test

  • docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0
  • Now that there are no mentions, create a software or project page, search for 10.3968/10006, it should be found using OpenAlex, but don't add it
  • Do a bulk import of mentions (use e.g. Mention feedback #808) including this DOI, it should be found, import them
  • Run the mentions scraper (a few times if necessary):
  • docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.doi.MainMentions
  • The scraped_at field at http://localhost/api/v1/mention should be set, no errors should be generated
  • Do some more testing with other DOIs (use e.g. Mention feedback #808) to see if everything still works

Closes #1321

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@ewan-escience ewan-escience self-assigned this Oct 18, 2024
Copy link

sonarcloud bot commented Oct 18, 2024

Copy link

sonarcloud bot commented Oct 18, 2024

@jmaassen
Copy link
Member

Nice work!

It also seems to work for DOIs minted by the EU, such as 10.2777/28598

@ewan-escience ewan-escience merged commit 2a1b6e2 into main Oct 21, 2024
6 checks passed
@ewan-escience ewan-escience deleted the 1321-doi-all-registry-agents branch October 31, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use OpenAlex scraper for all mentions with a DOI from an unsupported registry agent
3 participants