Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scraper for RSD aggregator #1355

Merged

Conversation

ewan-escience
Copy link
Collaborator

Scraper for RSD aggregator

Changes proposed in this pull request

  • Some small changes in the new database structure
  • Add the scraper for aggregating RSDs

How to test

  • docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=1
  • Run the following in the database: INSERT INTO remote_rsd(label, "domain") VALUES ('RSD', 'https://research-software-directory.org/') ,('NFDI', 'https://helmholtz.software/') ,('local', 'http://nginx/');
  • Note that we added localhost so we can also test the delete functionality
  • Wait for the scraper to run (should we within a minute) or run docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.aggregator.MainAggregator
  • Check if http://localhost/api/v1/remote_software has the expected results
  • Check if http://localhost/api/v1/rpc/aggregated_software_overview has the expected results
  • Sign in as admin, delete or unpublish a published software page, wait 5 minutes or clear the column scraped_at of the localhost entry: UPDATE remote_rsd SET scraped_at = NULL WHERE "label" = 'local';. The entry should be deleted.
  • There should be no errors of this scraper in the error logs or in the Docker output.

Partially implements #1287

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@ewan-escience ewan-escience self-assigned this Nov 28, 2024
@ewan-escience ewan-escience force-pushed the 1287-remote-rsd-search-scraper branch from 142872b to e5591de Compare November 28, 2024 14:10
Copy link

Copy link

Copy link
Contributor

@dmijatovic dmijatovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ewan-escience ewan-escience merged commit 0b217bc into 1287-remote-rsd-search Nov 28, 2024
7 checks passed
@ewan-escience ewan-escience deleted the 1287-remote-rsd-search-scraper branch February 7, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants