Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1359 linkedin auth #1361

Merged
merged 4 commits into from
Jan 10, 2025
Merged

1359 linkedin auth #1361

merged 4 commits into from
Jan 10, 2025

Conversation

ewan-escience
Copy link
Collaborator

Add LinkedIn as OpenID provider for signing in

Changes proposed in this pull request

  • Add LinkedIn as OpenID provider for signing in
  • Add documentation and fix some typos
  • Use status code 303 instead of the default (which happens to be 302) when redirecting after signing in, as it semantically and technically better fits the purpose
  • Remove unused functions and environment variables from the auth module

How to test

  • Copy the new env variables from .env.example to .env and fill in the missing values
  • docker compose down --volumes && docker compose build --parallel && docker compose up
  • Sign in with LinkedIn
  • Sign in with other providers to see if this still works

Closes #1359

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@ewan-escience ewan-escience self-assigned this Jan 8, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Failed Quality Gate failed for 'authentication'

Failed conditions
8.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Jan 8, 2025

Copy link
Contributor

@dmijatovic dmijatovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested:

  • SURF: it works
  • Azure: it works
  • ORCID: it works
  • LinkedIn: it works
  • Local: it works too
  • Helmholtz: it fails

I think the credentials I am using for Helmholtz are old/expired and the reason for failure. @cmeessen Can you test Helmholtz login please?

@ewan-escience
Copy link
Collaborator Author

Thanks for testing. For me, Helmholtz still works.

@ewan-escience ewan-escience merged commit 38ad159 into main Jan 10, 2025
6 of 7 checks passed
@ewan-escience ewan-escience deleted the 1359-linkedin-auth branch February 7, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support signing in with LinkedIn
2 participants