Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show rsd host in global search #1382

Merged
merged 1 commit into from
Jan 31, 2025
Merged

feat: show rsd host in global search #1382

merged 1 commit into from
Jan 31, 2025

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Jan 28, 2025

Show rsd host in global search

Closes #1377

Changes proposed in this pull request:

  • Global search result show rsd host only when remote rsd's are defined by admins  

How to test:

  • make start to build solution and create some test data
  • try global search. It should not shown remote rsd / domain
  • login as rsd admin and add remote rsd:
  • if used make start you will need to restart services to enable scrapers docker compose down && docker compose up -d
  • try global search after scrapers included data. The rsd host should be shown.

Links without @Domain

image

Example rsd_host

image

Example without remotes

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@dmijatovic dmijatovic changed the title feat: show rsd host in global search only when host are defined feat: show rsd host in global search Jan 28, 2025
Copy link

Copy link
Collaborator

@ewan-escience ewan-escience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't the idea to never show local names, even if remotes do exist?

@dmijatovic dmijatovic merged commit 140c0f3 into main Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve global search (v3)
3 participants