-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alternative ROR names #1398
Conversation
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Works well, even with other character sets. For example adding this one: https://ror.org/04v3ywz14 Also allows me to search on this: 中国农业大学 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well
Use alternative ROR names
Changes proposed in this pull request
organisation
table that stores extra ROR namesglobal_search
andorganisations_overview
to use these namesglobal_search
that didn't convert strings to the same case when doing a substring index lookupHow to test
docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0
Amsterdam University of Applied Sciences
andVrije Universiteit Amsterdam
docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.ror.MainRor
VU Amsterdam
andHogeschool van Amsterdam
(or substrings), the previously added organisations should show updocker compose down --volumes && docker compose up --scale data-generation=1
Nice to have
When adding a new organisation with a ROR ID, add the extra names immediately.
Closes #1386
PR Checklist:
docker-compose.yml