Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternative ROR names #1398

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Use alternative ROR names #1398

merged 5 commits into from
Feb 20, 2025

Conversation

ewan-escience
Copy link
Collaborator

Use alternative ROR names

Changes proposed in this pull request

  • Add a column in the organisation table that stores extra ROR names
  • Adapt the ROR scraper to harvest these names
  • Adapt global_search and organisations_overview to use these names
  • Fix a bug in global_search that didn't convert strings to the same case when doing a substring index lookup

How to test

  • docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0
  • Sign in, create a software of project page, publish it and add the organisations Amsterdam University of Applied Sciences and Vrije Universiteit Amsterdam
  • Wait for the ROR scraper to run or execute docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.ror.MainRor
  • In the global search bar, search for VU Amsterdam and Hogeschool van Amsterdam (or substrings), the previously added organisations should show up
  • Do the same on the organisation overview
  • For performance, rerun with data generation: docker compose down --volumes && docker compose up --scale data-generation=1
  • Search should be fast
  • Let the ROR scraper run a few times
  • Search should still be fast
  • Look at http://localhost/api/v1/organisation?ror_names=not.is.null&select=name,slug,name,website,ror_names,ror_names_string for ideas of ROR names to search for; note that the names of the organisations are randomly generated and don't match the ROR names

Nice to have

When adding a new organisation with a ROR ID, add the extra names immediately.

Closes #1386

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@ewan-escience ewan-escience self-assigned this Feb 18, 2025
Copy link

Copy link

Copy link

Copy link
Contributor

@dmijatovic dmijatovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jmaassen
Copy link
Member

jmaassen commented Feb 19, 2025

Works well, even with other character sets. For example adding this one:

https://ror.org/04v3ywz14
China Agricultural University

Also allows me to search on this:

中国农业大学

Copy link
Member

@jmaassen jmaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

@ewan-escience ewan-escience merged commit a5461c1 into main Feb 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization Aliasses cannot be found
3 participants