Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

938 verified organisation #968

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Aug 15, 2023

Verified organisation badge and claim organisation button

Closes #938

Changes proposed in this pull request:

  • Verified "banner" is changed into verified badge (icon with the tooltip). See example 1
  • If the organisation is not verified we show "claim organisation" button instead. See example 2
  • Claim an organisation modal is similar to Register organisation modal on the homepage. There are few minor adaptations:
    • Title is different
    • Start of the email body (content) is different

How to test:

  • make start to build and generate test data
  • Validate register organisation button on the homepage is working properly
  • Navigate to organisation overview. Validate verified organisation icond and mouseover message
  • Go to next page until you see not verified organisations. Then use icon button. The modal should appear. The title of the modal will be different and the organisation name is already present.
  • Validate Cancel button of the modal
  • Validate Send email button working and the content of the email. Please doble check all new messages.

Example 1 - Verified organisation

image

Example 2 - Claim organisation button

image

Example 3 - Claim an organisation form

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@dmijatovic dmijatovic changed the base branch from main to rsd-v2-release August 15, 2023 17:53
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

[rsd-database] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmaassen
Copy link
Member

Some comments:

  • the verified icon seems a bit 'heavy' compared to the other info in the tile. Can you make is smaller and lighter?
  • the claim organization icon is a bit of a strange choice. How about this one or this one
  • there is a typo in the claim organization pop up (became = become)

@dmijatovic
Copy link
Contributor Author

@jmaassen and @ewan-escience Thanks for the feedback. The changes are implemented. Can you approve it please?

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

[rsd-frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

57.7% 57.7% Coverage
0.0% 0.0% Duplication

@dmijatovic dmijatovic merged commit 4d442dd into rsd-v2-release Aug 17, 2023
4 checks passed
@dmijatovic dmijatovic deleted the 938-verified-organisation branch September 4, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative design for Verified organizations badge
3 participants