Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split related topics into related software and projects sections #990

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

dmijatovic
Copy link
Contributor

Related software and related project sections

Closes #983

Changes proposed in this pull request:

  • The related topic section on edit software and edit project page is split into 2 separate sections.
  • The title "Related tools" on software page is changed to "Related software" 
  • The order of related "items" is alphabetic on name/title

How to test:

  • make start to build app
  • login as rsd-admin if you want to manipulate existing items or create new item
  • navigate to edit software page, confirm that menu has two separate sections: related software and related projects
  • suggestions about used icons, titles and labels are welcome
  • navigate to edit project page, confirm that menu has two separate sections: related software and related projects
  • suggestions about used icons, titles and labels are welcome

Example edit software related software section

image

Example edit software related projects section

image

Example edit project related projects section

image

Example edit project related software section

image

Example relates software title on software page

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

…tions on software and project edit pages

tests: update e2e and unit tests
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

[rsd-frontend] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

38.4% 38.4% Coverage
12.2% 12.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@cmeessen cmeessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you 👍

@dmijatovic dmijatovic merged commit 686a566 into main Sep 22, 2023
3 of 4 checks passed
@dmijatovic dmijatovic deleted the 983-related-items-split branch September 28, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve visibility of "Related Projects" in edit view
3 participants