Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to find a clean way to integrate new changes here... might have to start over #1

Open
wants to merge 18 commits into
base: test-updates-to-golang-with-rebase
Choose a base branch
from

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Sep 13, 2023

No description provided.

cmisale and others added 18 commits September 12, 2023 15:20
Go clients need to call REAPI CLI functions.

Add Go bindings for REAPI CLI for resource module
initialization, destruction, match allocate,
cancel, and other common functions.
Go clients need to call REAPI module functions.

Add Go bindings for REAPI module for resource module
initialization, destruction, match allocate,
cancel, and other common functions.
Problem: the REAPI module assumes the resource module
is already initialized but does not open a handle
to it.

Open a handle to make calls with a resource module
instance.
Problem: the Golang bindings need to be tested
as part of the Fluxion testsuite.

Add a main Go test to initialize the resource module
and output strings for comparison with expected
outputs.
Problem: the main test file must be
built as part of the `make check` tests.

Configure autotools to build main.go
for sharness tests.
Problem: the test matrix does not have
an image with Go installed.

Create a new Docker image which installs
Go and adds `go` to `PATH`. Add the image
and additional tests to the CI test matrix.
Problem: the Fluxion sharness tests need to test the
Golang bindings.

Add a basic sharness test and expected outputs.
Problem: Go bindings can be more friendly to Go developers
Solution: This includes docstring changes, the main module path
to be under flux-framework, returning Go error instead of int,
and updating tests to return nil (no error) instead of 0. The
module path is fixed from a development variant to a
flux-framework one. Finally, it fixes the Go bindings to
use a struct instead of passing around a ctx variable. Our
goal with these final changes to the Go module is to make
the code more friendly to future go developers.

Signed-off-by: vsoch <[email protected]>
Go clients need to call REAPI CLI functions.

Add Go bindings for REAPI CLI for resource module
initialization, destruction, match allocate,
cancel, and other common functions.
Go clients need to call REAPI module functions.

Add Go bindings for REAPI module for resource module
initialization, destruction, match allocate,
cancel, and other common functions.
Problem: the REAPI module assumes the resource module
is already initialized but does not open a handle
to it.

Open a handle to make calls with a resource module
instance.
Problem: the Golang bindings need to be tested
as part of the Fluxion testsuite.

Add a main Go test to initialize the resource module
and output strings for comparison with expected
outputs.
Problem: the main test file must be
built as part of the `make check` tests.

Configure autotools to build main.go
for sharness tests.
Problem: the test matrix does not have
an image with Go installed.

Create a new Docker image which installs
Go and adds `go` to `PATH`. Add the image
and additional tests to the CI test matrix.
Problem: the Fluxion sharness tests need to test the
Golang bindings.

Add a basic sharness test and expected outputs.
Problem: Go bindings can be more friendly to Go developers
Solution: This includes docstring changes, the main module path
to be under flux-framework, returning Go error instead of int,
and updating tests to return nil (no error) instead of 0. The
module path is fixed from a development variant to a
flux-framework one. Finally, it fixes the Go bindings to
use a struct instead of passing around a ctx variable. Our
goal with these final changes to the Go module is to make
the code more friendly to future go developers.

Signed-off-by: vsoch <[email protected]>
@vsoch vsoch force-pushed the test-updates-to-golang-with-rebase branch 11 times, most recently from 80f9ffb to c056346 Compare September 16, 2023 05:00
@vsoch vsoch force-pushed the test-updates-to-golang-with-rebase branch from c056346 to fb58ec0 Compare September 28, 2023 00:28
@vsoch vsoch force-pushed the test-updates-to-golang-with-rebase branch 3 times, most recently from 95ee296 to 5704285 Compare September 29, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants