fix(react-email): Unwanted email re-renders when switching templates #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0b2e02f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielmfern
added
Package: react-email
gabrielmfern
force-pushed
the
fix/unwatend-email-renderings
branch
from
d2a9089 to
05c5472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem that was happening was something like this
CleanShot.2024-12-23.at.17.44.41.mp4
Every time the user navigated, even if it was to the same page already open, it would always re-render the email template, even if it was already rendered. When we first implemented the current architecture for the preview server, with Next.js 14, RSCs would always be cached in such a way that this navigation wouldn't re-render the RSC for the
/preview/[slug]page, but as of Next.js 15 this does not seem to be the case.The solution I chose for this was to store a cache for rendered emails in the server instead of in the client, this allows for the
renderEmailByPathto return the cache when navigating across pages but also leads to less code and easier maintainability.