Merge pull request #483 from reservoirprotocol/ted/fix-slippage-for-s…

…ame-chain-swaps Fix slippage displayed for same-chain-swaps
reservoirprotocol · Feb 21, 2025 · 9b08e07 · 9b08e07
2 parents 67a7f6d + 5be1e1d
commit 9b08e07
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/.changeset/neat-tigers-decide.md b/.changeset/neat-tigers-decide.md
@@ -0,0 +1,5 @@
+---
+'@reservoir0x/relay-kit-ui': patch
+---
+
+Fix slippage displayed for same-chain-swaps
diff --git a/packages/ui/src/components/common/TransactionModal/steps/ReviewQuoteStep.tsx b/packages/ui/src/components/common/TransactionModal/steps/ReviewQuoteStep.tsx
@@ -233,11 +233,10 @@ export const ReviewQuoteStep: FC<ReviewQuoteProps> = ({
     )
   })
 
-  const slippage =
-    quote?.details?.slippageTolerance?.destination?.percent ??
-    quote?.details?.slippageTolerance?.origin?.percent ??
-    '0'
-
+  const isSameChain = toToken?.chainId === fromToken?.chainId
+  const slippage = isSameChain
+    ? quote?.details?.slippageTolerance?.origin?.percent ?? '0'
+    : quote?.details?.slippageTolerance?.destination?.percent ?? '0'
   const slippageRating = getSlippageRating(slippage)
   const slippageRatingColor = ratingToColor[slippageRating]
 

diff --git a/packages/ui/src/components/widgets/FeeBreakdown.tsx b/packages/ui/src/components/widgets/FeeBreakdown.tsx
@@ -71,10 +71,10 @@ const FeeBreakdown: FC<Props> = ({
   const [rateMode, setRateMode] = useState<'input' | 'output'>('input')
 
   const isHighPriceImpact = Number(price?.details?.totalImpact?.percent) < -3.5
-  const slippage =
-    price?.details?.slippageTolerance?.destination?.percent ??
-    price?.details?.slippageTolerance?.origin?.percent ??
-    '0'
+  const isSameChain = toToken?.chainId === fromToken?.chainId
+  const slippage = isSameChain
+    ? price?.details?.slippageTolerance?.origin?.percent ?? '0'
+    : price?.details?.slippageTolerance?.destination?.percent ?? '0'
 
   const slippageRating = getSlippageRating(slippage)
   const slippageRatingColor = ratingToColor[slippageRating]