-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Sync and bulk operations & new actuators #61
base: master
Are you sure you want to change the base?
Conversation
Ok perfect. I'm waiting for your comments. |
I do not understand why current-based position control mode is mixed with current control mode in f81be4c. I believe that we should create a new operating mode rather than mix them together when they are not exactly identical. |
Exactly I forgot to recall it correctly. the correct term should be Actually, PWM is the more common term for controlling a servo. Basically we can call it |
the documentation mentions that both current and position are controlled in this mode. I don't think that it is multi turn torque then. Am I wrong ?
Sounds good. Would you do it ? Besides, do you know if there finally is a table merging all the control tables of all the servo models, so that we can be sure to not miss implementation details ? It starts to be pretty complex to check the control tables for coherence. If not, I would think on how to build one and have it be updated. |
I will do it concerning the PWM/voltage modification. All controls tables are common for a specific servo series. I mean most of the MX servo series share identical control table but sometimes they are some specific address concerning one model. So it's really hard to be consistent, but the idea should be to build one specific control table for each servo series. |
On some OS, EWOULDBLOCK has the same value as EAGAIN and would hence not compile. Then we decided to comment that.
|
I would then suggest either to add OS-specific macros (as JB did in the baudrate files) or to remove this code altogether. I think that the former option is better, if feasible, as it would catch more errors properly. |
I have tried to add an OS-spefic macro, it compiles on my side (Ubuntu 16.04). The merge with dev-dogoepp is done. Let me know if we need to revise anything else. |
This is a Work in Progress pull request so that we can discuss about it. I will soon add my comments and suggestions.