Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: husky를 설치하고 byul설치 오류 (#68) #69

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

nakyeonko3
Copy link
Collaborator

@nakyeonko3 nakyeonko3 commented Sep 26, 2024

  • setup.mjs에서 npx husky add를 이용해서 byul 스크립트를 설치할 때
    오류가 생김.
  • npx husky add가 더이상 지원되지 않는 명령어라서 이런 에러가 발생
  • setup.mjs에서 echo 'node node_modules/byul/dist/index.js "$1" "$2" "$3"' >
    ${hookFile} 로 수정함.

오류 내용

image

setup.mjs 수정된 부분

image

Summary by CodeRabbit

  • 버전 업데이트
    • 패키지 버전이 2.0.3에서 2.0.4로 업데이트되었습니다.

- setup.mjs에서 npx husky add를 이용해서 byul 스크립트를 설치할 때
  오류가 생김.
- npx husky add가 더이상 지원되지 않는 명령어라서 이런 에러가 발생
- setup.mjs에서 echo 'node node_modules/byul/dist/index.js "$1" "$2" "$3"' >
  ${hookFile} 로 수정함.
Copy link

coderabbitai bot commented Sep 26, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

이 변경 사항은 package.json 파일의 version 필드가 "2.0.3"에서 "2.0.4"로 업데이트된 것을 포함합니다. 이는 패키지의 새로운 릴리스를 나타내는 버전 번호의 증가를 반영합니다.

Changes

파일 변경 요약
package.json version 필드가 "2.0.3"에서 "2.0.4"로 업데이트됨

Possibly related issues

  • byulhook/byul#68: husky에서 byul 설치 실패 문제와 관련이 있을 수 있으며, 버전 업데이트가 이 문제를 해결하는 데 기여할 수 있음.

Suggested reviewers

  • love1ace

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from love1ace September 26, 2024 04:02
@github-actions github-actions bot added the fix 버그 (버그 수정) label Sep 26, 2024
@love1ace love1ace merged commit fad740c into develop Sep 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 (버그 수정)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants