Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thundagun 1.1.1 #146

Merged
merged 8 commits into from
Nov 22, 2024
Merged

Add Thundagun 1.1.1 #146

merged 8 commits into from
Nov 22, 2024

Conversation

DoubleStyx
Copy link
Contributor

No description provided.

@Frozenreflex
Copy link

Frozenreflex commented Nov 15, 2024

I'm not entirely sure how projects with multiple contributors work, and I've never even remotely touched the manifest before, but I took a brief look for prior examples, this seems to be standard, and it seems weird that I (or any of the other contributors) don't get credit in the manifest for this, and that goes for any other instances of mods with multiple contributors

@DoubleStyx
Copy link
Contributor Author

Is it possible to do something like this?

{
    "author": {
        "Fro Zen": {
            "url": "https://github.com/Frozenreflex/Thundagun"
        },
        "989onan": {
            "url": "https://github.com/Frozenreflex/Thundagun"
        },
        "DoubleStyx": {
            "url": "https://github.com/Frozenreflex/Thundagun"
        },
        "Nytra": {
            "url": "https://github.com/Frozenreflex/Thundagun"
        }
    }
}

@Frozenreflex
Copy link

I have no idea if that's valid for their json schema, but if that's valid then I'm fine with that, I'm probably never gonna make any new mods for Reso so I'm fine with having y'all there.

@DoubleStyx
Copy link
Contributor Author

I edited this pr to use the author name on the repo itself for consistency. I would like to get credit for this as well, in addition to the others who helped get the mod to its current state. If this is not currently supported, perhaps it can be an issue for the manifest repo.

@DoubleStyx
Copy link
Contributor Author

And I don't know if that's valid; it was just an inference.

@Nytra
Copy link
Contributor

Nytra commented Nov 15, 2024

@DoubleStyx
Copy link
Contributor Author

Added other mod contributors to additional authors field.

@XDelta XDelta added the Community PR Manifest additon made for somone else's mod(s) label Nov 15, 2024
@DoubleStyx
Copy link
Contributor Author

Is this ready for merging, or does something need to be changed?

@Nytra
Copy link
Contributor

Nytra commented Nov 19, 2024

@DoubleStyx DoubleStyx changed the title Add Thundagun 1.1.1-beta Add Thundagun 1.1.1 Nov 19, 2024
@DoubleStyx
Copy link
Contributor Author

Should hopefully be good now?

@DoubleStyx
Copy link
Contributor Author

Is there anything here that still needs to be resolved?

@XDelta XDelta merged commit e4864e4 into resonite-modding-group:main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR Manifest additon made for somone else's mod(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants