Added Scroll to top feature #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
manojVivek
requested changes
Jun 7, 2024
There was a problem hiding this comment.
@sagarhedaoo Thank you so much for this contribution, just a minor change request. Looks great otherwise!
| @@ -495,6 +495,61 @@ const Device = ({ isPrimary, device, setIndividualDevice }: Props) => { | |||
| const scaledHeight = height * zoomfactor; | |||
| const scaledWidth = width * zoomfactor; | |||
|
|
|||
| useEffect(() => { | |||
| const webview = ref.current; | |||
There was a problem hiding this comment.
I would say, we don't need this button inside the view. We don't want to pollute the user space with the app code.
The icon in the toolbar is good enough and this just feels like a redundant cta. Can you please remove this?
There was a problem hiding this comment.
Took a stab at it myself.
|
@sagarhedaoo Thanks again for your effort on this! ❤️ |
|
@all-contributors Please add @sagarhedaoo for code. |
|
I've put up a pull request to add @sagarhedaoo! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Link: #1234
Fixes: #1234
ℹ️ About the PR
I implemented the Scroll to top feature in the webview as well as in the toolbar. The Button disappears when the user is at the top of the page and when user goes down then it appears.
Upon clicking it scrolls back to the top.
Same for the toolbar button that I added/
🖼️ Testing Scenarios / Screenshots
I used command yarn test to test the code before pushing it with all the test cases passed.