Throttle calls to a custom configuration loader #142
Conversation
Many custom configuration loaders will retrieve the configuration from an external resource. `Resque::Pool` asks the loader for the latest configuration roughly once per second. You may want to reduce load on your external resource by caching the value, and only really fetching the latest configuration after a specific amount of time has passed. Instead of forcing each configuration loader author to re-write (and test) this logic, we provide `Resque::Pool::ConfigThrottle`. See the spec for full details of its behavior.
|
This is great! This composability is exactly direction I was hoping to go with the config loader bits. I just pushed an (unfinished work in progress) branch where I broke the default config loader down into |
|
|
||
| def call(env) | ||
| # We do not need to cache per `env`, since the value of `env` will not | ||
| # change during the life of the process. |
There was a problem hiding this comment.
This comment (and my own playing around with decomposing the default loader) makes me feel that sending in env as an argument to call is the wrong API. I'm currently thinking that environment should be passed in to the config loader's initialize, so we can codify the assumption that env will not change.
There was a problem hiding this comment.
I came to the same conclusion. Not every config loader will care about the environment - in fact most probably won't.
I agree that any config loader that has a dependency on other information (redis connection, db connection, current environment, etc) should take that info via the constructor.
|
Totally agree about the composability. The |
Many custom configuration loaders will retrieve the
configuration from an external resource.
Resque::Poolasks the loader for the latest configuration roughly
once per second. You may want to reduce load on your
external resource by caching the value, and only
really fetching the latest configuration after a
specific amount of time has passed.
Instead of forcing each configuration loader author
to re-write (and test) this logic, we provide
Resque::Pool::ConfigThrottle.See the spec for full details of its behavior.