Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Short_t by UShort_t in raw signal #116

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Replace Short_t by UShort_t in raw signal #116

wants to merge 3 commits into from

Conversation

lobis
Copy link
Member

@lobis lobis commented Aug 8, 2023 •
edited
Loading

@lobis lobis linked an issue Aug 8, 2023 that may be closed by this pull request
TRestRawSignal should use unsigned short instead of signed short #115
Open
@lobis lobis added the enhancement New feature or request label Aug 8, 2023
@lobis lobis requested review from jgalan and juanangp August 8, 2023 16:32
@lobis
Copy link
Member Author

lobis commented Aug 8, 2023

@jgalan @juanangp let me know if you are okay with this, so far it looks like it does not break anything except some processes in connectorslib that are easy to fix.

@juanangp
Copy link
Member

juanangp commented Aug 8, 2023

@jgalan @juanangp let me know if you are okay with this, so far it looks like it does not break anything except some processes in connectorslib that are easy to fix.

I have nothing against this implementation, but perhaps it breaks backward compatibility, would be good to check that as well.

@lobis
Copy link
Member Author

lobis commented Aug 8, 2023

@jgalan @juanangp let me know if you are okay with this, so far it looks like it does not break anything except some processes in connectorslib that are easy to fix.

I have nothing against this implementation, but perhaps it breaks backward compatibility, would be good to check that as well.

It probably breaks backwards compatibility yes, but so does many changes we do, so I think we should not rule it out because of this. Maybe we should include this on a large release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgalan jgalan Awaiting requested review from jgalan

@juanangp juanangp Awaiting requested review from juanangp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TRestRawSignal should use unsigned short instead of signed short
2 participants
@lobis @juanangp