Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for saving and verifying deposit data files #4

Merged
merged 9 commits into from
Nov 14, 2023

Conversation

mllnd
Copy link
Contributor

@mllnd mllnd commented Nov 13, 2023

No description provided.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eaff86e) 94.66% compared to head (67cd04c) 95.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   94.66%   95.19%   +0.52%     
==========================================
  Files          16       16              
  Lines         300      333      +33     
  Branches       12       16       +4     
==========================================
+ Hits          284      317      +33     
  Misses         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mllnd mllnd force-pushed the feature/deposit-data-saving branch from 4bc9d3f to 1787556 Compare November 13, 2023 17:51
@mllnd mllnd force-pushed the feature/deposit-data-saving branch from 1787556 to bea566f Compare November 13, 2023 17:55
@mllnd mllnd requested a review from mikroskeem November 13, 2023 18:22
@mllnd mllnd marked this pull request as ready for review November 13, 2023 18:22
cli/subcommands/create_validators/command.ts Outdated Show resolved Hide resolved
cli/subcommands/create_validators/command.ts Outdated Show resolved Hide resolved
@mllnd mllnd requested a review from mikroskeem November 14, 2023 10:30
@mllnd mllnd force-pushed the feature/deposit-data-saving branch 2 times, most recently from d57f52a to 2e8a644 Compare November 14, 2023 10:39
@mllnd mllnd force-pushed the feature/deposit-data-saving branch from 2e8a644 to 492f40a Compare November 14, 2023 10:40
keygen/deposit_data.ts Outdated Show resolved Hide resolved
keygen/deposit_data.ts Outdated Show resolved Hide resolved
@mllnd mllnd merged commit 6fde90a into master Nov 14, 2023
5 checks passed
@mllnd mllnd deleted the feature/deposit-data-saving branch November 14, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants