Fix some gradle configuration #247
Conversation
…estReports are automatically generated by the built-in test configuration.
…r doesn't exit on the first failed test configuration, but runs all the test tasks, then fails.
build.gradle.kts
Outdated
| java { toolchain { languageVersion = JavaLanguageVersion.of(11) } } | ||
| java { | ||
| sourceCompatibility = JavaVersion.VERSION_17 | ||
| targetCompatibility = JavaVersion.VERSION_17 | ||
| } |
There was a problem hiding this comment.
This toolchain thing fixes to a specific java version, which causes #237. Using source/target compatibility should work with any sdk version >= 17
There was a problem hiding this comment.
I tried now to enable the auto jvm download in the last commit, it sounds like a useful feature. I wonder though if it works on NixOS, perhaps @igalshilman give this a try to see if your machine likes it :)
There was a problem hiding this comment.
I can confirm that it works on my machine as well. Thanks @slinkydeveloper for working your magic on this ❤️
slinkydeveloper
force-pushed
the
fix-gradle
branch
from
b5f2cfc to
80d88fc
Compare
There was a problem hiding this comment.
Thanks a lot for improving our e2e tests @slinkydeveloper. I think it is a really good improvement. I've tested them locally and it seems to work :-) +1 for merging.
| check { | ||
| dependsOn(testAlwaysSuspending) | ||
| dependsOn(testSingleThreadSinglePartition) | ||
| dependsOn(testPersistedTimers) | ||
| dependsOn(testLazyState) | ||
| } |
There was a problem hiding this comment.
Nice, really cool. Now it is actually possible to run individually tests via --tests. I think this is now also possible because you've removed the explicit TestReport task. Really good! I guess we can then also close #115.
There was a problem hiding this comment.
I didn't notice that I fixed that as well 🤣
A bunch of fixes for the gradle configuration, including fix #237 (first commit)