Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datafusion] prepend physical_optimizer_rule before other rules #2114

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[datafusion] prepend physical_optimizer_rule before other rules #2114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce3ad14
[datafusion] prepend physical_optimizer_rule before other rules
igalshilman Oct 16, 2024
29c75f6
[datafusion] Use the builder instead of a deprecated method
igalshilman Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions crates/storage-query-datafusion/src/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use datafusion::error::DataFusionError;
use datafusion::execution::context::SQLOptions;
use datafusion::execution::runtime_env::{RuntimeConfig, RuntimeEnv};
use datafusion::execution::SessionStateBuilder;
use datafusion::physical_optimizer::PhysicalOptimizerRule;
use datafusion::physical_optimizer::optimizer::PhysicalOptimizer;
use datafusion::physical_plan::SendableRecordBatchStream;
use datafusion::prelude::{SessionConfig, SessionContext};

Expand Down Expand Up @@ -225,13 +225,14 @@ impl QueryContext {
// A far more involved but potentially more robust solution would be wrap the SymmetricHashJoin in a ProjectionExec
// If this would become an issue for any reason, then we can explore that alternative.
//
let physical_optimizers: Vec<Arc<dyn PhysicalOptimizerRule + Send + Sync>> =
vec![Arc::new(physical_optimizer::JoinRewrite::new())];
let join_rewrite = Arc::new(physical_optimizer::JoinRewrite::new());
let mut default_physical_optimizer_rules = PhysicalOptimizer::default().rules;
default_physical_optimizer_rules.insert(0, join_rewrite);

state_builder = state_builder.with_physical_optimizer_rules(physical_optimizers);
state_builder =
state_builder.with_physical_optimizer_rules(default_physical_optimizer_rules);

let state = state_builder.build();

let ctx = SessionContext::new_with_state(state);

let sql_options = SQLOptions::new()
Expand Down
Loading