Option to disable LogsController
#2529
Open
+184
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
force-pushed
the
pr2529
branch
2 times, most recently
from
81c6b57 to
22bded5
Compare
Summary: Support disabling logs controller via a configuration flag Instead of checking the flag everywhere. If flag is set, logs controller is replaced with a `no-op` logs controller.
|
Let's wait on this one until we see how logs-controller will be shaped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to disable
LogsControllerSummary:
Support disabling logs controller via a configuration flag
Instead of checking the flag everywhere. If flag is set, logs
controller is replaced with a
no-oplogs controller.