Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Partition placement based on nodeset selector #2545

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Jan 24, 2025

  • Tests were not refactored, so build on GHA is expected to fail
  • This will cause a few errors on start of partitions due to log not being found until it's provisioned by log-controller

Stack created with Sapling. Best reviewed with ReviewStack.

- Tests were not refactored, so build on GHA is expected to fail
- This will cause a few errors on start of partitions due to log not being found until it's provisioned by log-controller
Copy link

github-actions bot commented Jan 24, 2025

Test Results

  7 files  ±0    7 suites  ±0   3m 22s ⏱️ -51s
 45 tests  - 2   44 ✅  - 2  1 💤 ±0  0 ❌ ±0 
174 runs   - 8  171 ✅  - 8  3 💤 ±0  0 ❌ ±0 

Results for commit 5b6aea1. ± Comparison against base commit 0ca8e3f.

This pull request removes 2 tests.
dev.restate.sdktesting.tests.AwaitTimeout ‑ timeout(Client)
dev.restate.sdktesting.tests.RawHandler ‑ rawHandler(Client)

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant