Improvements to ClusterTables #3351
Conversation
|
|
cc. @pcholakov for |
👍 makes sense to me, it was a PR suggestion that I should have rejected. |
There was a problem hiding this comment.
This looks really good. Thank you @AhmedSoliman for this PR. LGTM!
There was a problem hiding this comment.
Thanks a lot for updating our df tables @AhmedSoliman. The changes look good to me. +1 for merging :-)
| /// Current known metadata version | ||
| metadata_ver: DataType::UInt32, |
There was a problem hiding this comment.
Should we rename this into partition table version? I was for a second confused which metadata version this field refers to. On the other hand, it is in the partition table where it makes sense that this is the partition table version.
There was a problem hiding this comment.
I'll follow through with the rest of the tables as well to make them consistent
This updates cluster tables in datafusion (restatectl sql): - Removes `node_state` as it doesn't align with the admin-less design. - Adds `state` in `node` table that uses gossip to show liveness - `partitions` table exposes v_current/v_next and replica-sets from gossip - Removes `persisted_lsn` since those tables are not meant to be backward compatible. ClusterTables are still internal/restatectl only
This updates cluster tables in datafusion (restatectl sql):
node_stateas it doesn't align with the admin-less design.stateinnodetable that uses gossip to show livenesspartitionstable exposes v_current/v_next and replica-sets from gossippersisted_lsnsince those tables are not meant to be backward compatible. ClusterTables are still internal/restatectl only