Update SDK to use restatedev/service-protocol#58 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,8 +19,9 @@ | |||
|
|
|||
| class CounterTest { | |||
|
|
|||
| @SuppressWarnings("unused") | |||
sdk-core/src/main/java/dev/restate/sdk/core/RestateServerCall.java
Outdated
Show resolved
Hide resolved
sdk-core/src/test/java/dev/restate/sdk/core/StateTestSuite.java
Outdated
Show resolved
Hide resolved
|
I mistakenly already introduced on main your protocol changes, you can remove the commits pulling the subtree changes. |
tillrohrmann
force-pushed
the
issues/187
branch
from
6c5aa0f
to
407207f
Compare
|
I've rebased and addressed your comments @slinkydeveloper. PTAL. |
slinkydeveloper
approved these changes
Dec 18, 2023
tillrohrmann
force-pushed
the
issues/187
branch
from
407207f
to
d7d6b44
Compare
Calling listener.cancel is problematic in the Kotlin case because it terminates the Kotlin coroutine via an exception which will be caught and triggers outputting the ErrorMessage.
This commit updates the Java SDK to allow all completable journal entries to have a failure variant. As part of this change, we also added tests to ensure the correct behavior. This fixes restatedev#187.
tillrohrmann
force-pushed
the
issues/187
branch
from
d7d6b44
to
623060f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Java SDK to allow all completable journal entries
to have a failure variant. As part of this change, we also added tests to
ensure the correct behavior.
This fixes #187.