Skip to content

Commit

Permalink
fix: print the actual address listened on
Browse files Browse the repository at this point in the history
This is useful when the server is started with an ephemeral port, e.g.:

./rest-server --no-auth --listen "127.0.0.1:0"

...

start server on 127.0.0.1:46015
  • Loading branch information
ae-govau committed Feb 4, 2024
1 parent 3ce6aaf commit 03ad242
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 2 deletions.
17 changes: 17 additions & 0 deletions changelog/unreleased/pull-271
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
Enhancement: after start-up, server served message now prints actual listen address

For example, when started with `--listen :0`, previously the server would print:

```
start server on :0
```

Now it will print the actual address listened on, e.g.

```
start server on 0.0.0.0:37333
```

This is useful when starting a server with an auto-allocated free port number (port 0).

https://github.com/restic/rest-server/pull/271
2 changes: 1 addition & 1 deletion cmd/rest-server/listener_unix.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func findListener(addr string) (listener net.Listener, err error) {
return nil, fmt.Errorf("listen on %v failed: %w", addr, err)
}

log.Printf("start server on %v", addr)
log.Printf("start server on %v", listener.Addr())
return listener, nil

case 1:
Expand Down
2 changes: 1 addition & 1 deletion cmd/rest-server/listener_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ func findListener(addr string) (listener net.Listener, err error) {
return nil, fmt.Errorf("listen on %v failed: %w", addr, err)
}

log.Printf("start server on %v", addr)
log.Printf("start server on %v", listener.Addr())
return listener, nil
}

0 comments on commit 03ad242

Please sign in to comment.