add missing tests #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| require 'rubygems' | |||
| require 'bundler/setup' | |||
| require 'pry' | |||
|
@GonchuB it's cleaner now |
gschammah
force-pushed
the
feature/ensure_alternative
branch
from
d3aa55f to
1784218
Compare
| ab_user[experiment_name] = default_alternative = alternatives.first | ||
| Split::Alternative.new(default_alternative, experiment_name).increment_participation | ||
| @alternative_ensured = true | ||
| # If the user doesn't have an alternative set, we override the alternative and we manually increment the |
There was a problem hiding this comment.
If the user doesn't have an alternative set, we override the alternative It doesn't makes much sense
|
muy muy buenos tests 👍 |
|
el caso del |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ndrisso please check it again