feat: 교육 사항 등록 기능 구현 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juhongseok
reviewed
Oct 24, 2023
| this.title = title; | ||
| this.introduce = introduce; | ||
| this.user = user; | ||
| this.training = training; |
| @Column(name = "training_id") | ||
| private Long id; | ||
|
|
||
| private String schoolOrOrganization; |
There was a problem hiding this comment.
단순 '기관' 이라는 단어로 칭해도 될 거 같아요
피그마에 나온대로 다 작성은 안해도 될듯?
Comment on lines
66
to
69
| if (this.role == Role.ROLE_MENTEE) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Suggested change
| if (this.role == Role.ROLE_MENTEE) { | |
| return true; | |
| } | |
| return false; | |
| return role.equals(Role.ROLE_MENTEE); |
| } | ||
|
|
||
| @Test | ||
| void max_gpa_should_be_greater_than_gpa() { |
ddongpuri
reviewed
Oct 24, 2023
|
|
||
| @Enumerated(EnumType.STRING) | ||
| private Position position; | ||
|
|
||
| @Lob | ||
| private String introduce; | ||
|
|
||
| @Embedded | ||
| @ManyToOne |
There was a problem hiding this comment.
내가 가진 여러개의 이력서가 하나의 교육 사항을 공유하나요?
이력서 하나에 교육사항 하나만 작성 가능한지도 궁금합니다!
ddongpuri
reviewed
Oct 24, 2023
| } | ||
| return false; | ||
| } | ||
|
|
|
커밋에서 test나 엔티티수정, 검증로직 추가 이런것들은 하나로 합쳐도 좋을 것 같아요 |
Juhongseok
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖥️ 이런 PR 입니다
교육 사항 등록 기능 구현하였습니다.
CC. 리뷰어
User 클래스에 멘티인지 확인하는 메소드 추가하였습니다. @ddongpuri
테스트 설명
검증로직 예외 발생 테스트
기타
Prefix
PR 코멘트를 작성할 때 항상 Prefix를 붙여주세요.