Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 컴포넌트 아토믹 구조로 분리 #272

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

backward99
Copy link
Contributor

💻 스크린샷 (선택사항)

📃 PR 설명

하나의 폴더안에 있던 컴포넌트들을 아토믹 구조에 맞게 분리했습니다.

📃 참고사항

🔎 PR포인트 및 궁금한 점

Details와 같이 묶어 놓은 파일도 분리 시키는게 좋을까요?

@backward99 backward99 added the 🛠 Refactor 리팩토링한 경우(리팩토링 과정에서 파일 삭제, 이동 포함) label Jan 14, 2024
@backward99 backward99 self-assigned this Jan 14, 2024
Copy link
Member

@leeminhee119 leeminhee119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 !!
Details와 같이 묶어놓은 폴더는 어떤 걸 얘기하시는 건지 구체적으로 알려주실 수 있을까요?

@backward99 backward99 force-pushed the refactor/storybook-atomic-structure branch from acc83ff to 417353d Compare January 15, 2024 04:38
Base automatically changed from refactor/storybook-atomic-structure to main January 15, 2024 04:39
@backward99 backward99 force-pushed the refactor/component-atomic-restructure branch from 6f0a1c3 to 03eaa29 Compare January 15, 2024 04:41
@backward99 backward99 force-pushed the refactor/component-atomic-restructure branch from 03eaa29 to 39fb685 Compare January 15, 2024 04:42
@backward99
Copy link
Contributor Author

organisms/ResumeDetails
templates/EditProfileTemplate
폴더 내부에 있는 파일입니다!

@leeminhee119
Copy link
Member

organisms/ResumeDetails templates/EditProfileTemplate 폴더 내부에 있는 파일입니다!

아하 저는 이건 그대로 폴더로 묶어놓는 게 찾아보기에 더 편할 것 같아요!

@backward99
Copy link
Contributor Author

좋습니다!

@backward99 backward99 merged commit ec8c8fb into main Jan 15, 2024
1 check passed
@backward99 backward99 deleted the refactor/component-atomic-restructure branch January 15, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Refactor 리팩토링한 경우(리팩토링 과정에서 파일 삭제, 이동 포함)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants