refactor: Form 컴포넌트 구조 리팩토링 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backward99
approved these changes
Feb 26, 2024
Comment on lines
+65
to
+68
| <CategoryAddHeader | ||
| categoryTitle={'프로젝트'} | ||
| onAddItem={() => setIsOpenStates((prev) => ({ ...prev, project: true }))} | ||
| /> |
There was a problem hiding this comment.
해당 부분이 Form 밖에 나오기 이전(삭제된 src/components/organisms/ResumeCategoryProject/ProjectForm.tsx 파일)에는 isEdit에 따라 표시 유무가 바뀐 것 같습니다. 이전과 조금 다르게 보일까요?
There was a problem hiding this comment.
보이는 건 이전과 같습니다!
이력서 카테고리 상세 컴포넌트인 ResumeCategoryDetails에서, 사용자가 수정을 클릭한 경우에는 Form 컴포넌트를 렌더링하고 그렇지 않은 경우에는 (default) Detail 컴포넌트를 렌더링하고 있어요.
이전에는 Form 컴포넌트가 CategoryAddHeader까지 포함하고 있었어서, 사용자가 수정을 클릭한 경우 CategoryAddHeader가 중복으로 나타나게 돼버려서 (이미 EditResumeTemplate에 Form컴포넌트가 있으니까요) isEdit인 경우에는 렌더링하지 않도록 했었습니다.
지금은 CategoryAddHeader를 바깥으로 분리해서 이 문제가 해결되니 분기처리를 없애줬습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 스크린샷 (선택사항)
📃 PR 설명
📃 참고사항
🔎 PR포인트 및 궁금한 점