Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#134 Improve success condition to handle empty slice #135

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

tcpkump
Copy link
Contributor

@tcpkump tcpkump commented Jun 5, 2024

This resolves a condition where ResourceStatuses is empty, but the run was still successful.

Closes #134

Copy link

@krzee krzee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have tested this code on my servers and it fixes my problem #134

@eriksw eriksw merged commit 414786a into retailnext:master Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

puppet_last_run_success is only 1 when changes were made by puppet
3 participants